Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Avoid superfluous calls and code #1551

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Dec 3, 2019

LGTM.com often identifies some issues not found by ESLint; this PR fixes the issues found at https://lgtm.com/projects/g/benmosher/eslint-plugin-import/?mode=list . In this case, they are just some harmless superfluous arguments and redundant checks, but helpful to fix both for clarity and to reduce noise among the lgtm alerts.

(The site has a Github integration which I find worth adding to check PRs.)

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage increased (+0.09%) to 96.391% when pulling 14c71a3 on brettz9:superfluous into c37e42f on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.12% when pulling 5607f3a on brettz9:superfluous into 112a0bf on benmosher:master.

6 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.12% when pulling 5607f3a on brettz9:superfluous into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.12% when pulling 5607f3a on brettz9:superfluous into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.12% when pulling 5607f3a on brettz9:superfluous into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.12% when pulling 5607f3a on brettz9:superfluous into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.12% when pulling 5607f3a on brettz9:superfluous into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 96.12% when pulling 5607f3a on brettz9:superfluous into 112a0bf on benmosher:master.

src/core/importType.js Outdated Show resolved Hide resolved
@ljharb ljharb merged commit 14c71a3 into import-js:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants